-
Notifications
You must be signed in to change notification settings - Fork 6.3k
refactor: drop db migration patch #5519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Drop migration code since it's been 6 months since 4.0.2 and we no longer need this. See: #5482 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@code-asher I refreshed all the patches. Does this look okay to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the blocks shifted a little, probably due to using a different diff algorithm, but I think it should be fine! Looks like I am using patience (you can see what you have by running git config diff.algorithm in the code-server repo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh...looks like I'm not using one? 😅 Reminds me of when I first started at Coder and Anmol/I were using different algorithms.
Okay I will leave as is for now then and merge this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that probably means it is using the default (myers).
Codecov Report
Merging #5519 (1afc8fb) into main (ef3f4e8) will not change coverage.
The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@ ## main #5519 +/- ## ======================================= Coverage 72.44% 72.44% ======================================= Files 30 30 Lines 1673 1673 Branches 366 366 ======================================= Hits 1212 1212 Misses 398 398 Partials 63 63
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update ef3f4e8...1afc8fb. Read the comment docs.
This was supposed to be removed in #5519 Looks like I didn't update the series or actually delete the patch.
* chore: update Code to 1.72.2 * chore: refresh integration patch * chore: refresh base-path * chore: refresh proposed-api patch * chore: refresh marketplace patch * chore: refresh webview patch * chore: refresh disable-builtin patch * chore: refresh logout, update-check patches * chor: refresh proxy-uri patch * fix: delete unique-db patch This was supposed to be removed in #5519 Looks like I didn't update the series or actually delete the patch. * fix: drop log-level patch This was merged upstream! * chore: refresh local-storage patch * chore: refresh service-worker patch * chore: refresh sourcemaps patch * chore: refresh disable-downloads patch * chore: refresh telemetry patch * chore: refresh language patch * chore: refresh cli-window-open patch * Revert "fix: delete unique-db patch" This reverts commit ca0506c. * fixup!: rm extra spaces integration patch * fixup: space * fixup! update unique-db patch * fixup!: update hash in webview patch * fixup! update marketplace patch * fixup!: remove comma
Uh oh!
There was an error while loading. Please reload this page.
This drops the patch and also the tests (which were flakey and our longest running e2e tests).
Fixes #5482