-
Notifications
You must be signed in to change notification settings - Fork 6.3k
chore: update code to 1.70.2 #5485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@fritterhoff thank you! do the patches need to be updated/refreshed?
Nope. No changes required.
Codecov Report
❗ No coverage uploaded for pull request base (
main@90f6035
). Click here to learn what that means.
The diff coverage isn/a
.
@@ Coverage Diff @@ ## main #5485 +/- ## ======================================= Coverage ? 72.44% ======================================= Files ? 30 Lines ? 1673 Branches ? 366 ======================================= Hits ? 1212 Misses ? 398 Partials ? 63
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 90f6035...4031c6c. Read the comment docs.
Amazing! I'll checkout locally and test. Also requesting review from @code-asher - once we both ✅, we can merge.
- [Chromium] › extensions.test.ts:8:3 › Extensions › should have access to VSCODE_PROXY_URI =====
We know this test is flakey. #5481 should reduce that a bit.
All looks good. I did notice a weird flash of the terminal prompt but I don't know if that's related to zsh
or my think 🤔 anyone else see this?
Screen.Recording.2022年08月22日.at.10.07.26.AM.mov
I am not seeing my prompt doing that (using Bash). My guess is it is either ZSH or the predictive output but probably unrelated to this PR.
Actually maybe they did change something...when I run ZSH there is a slight flash but not with 4.6.0. Weird.
Ah nevermind I see it on 4.6.0 as well, just at a different frequency.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #5470
How to test locally