Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update code to 1.70.2 #5485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 3 commits into coder:main from fritterhoff:main
Aug 22, 2022
Merged

chore: update code to 1.70.2 #5485

jsjoeio merged 3 commits into coder:main from fritterhoff:main
Aug 22, 2022

Conversation

Copy link
Contributor

@fritterhoff fritterhoff commented Aug 21, 2022
edited by jsjoeio
Loading

Fixes #5470

How to test locally

  1. clone, update submodule, and install deps
gh pr checkout 5485 && git submodule update --init && quilt push -a && yarn
  1. run locally:
yarn watch
  1. open localhost:8080
  2. test basic functions - open files, terminal, etc.

Copy link
Contributor

jsjoeio commented Aug 22, 2022

@fritterhoff thank you! do the patches need to be updated/refreshed?

Copy link
Contributor Author

Nope. No changes required.

jsjoeio reacted with hooray emoji

Copy link

codecov bot commented Aug 22, 2022
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@90f6035). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #5485 +/- ##
=======================================
 Coverage ? 72.44% 
=======================================
 Files ? 30 
 Lines ? 1673 
 Branches ? 366 
=======================================
 Hits ? 1212 
 Misses ? 398 
 Partials ? 63 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f6035...4031c6c. Read the comment docs.

@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Aug 22, 2022
Copy link
Contributor

jsjoeio commented Aug 22, 2022

Amazing! I'll checkout locally and test. Also requesting review from @code-asher - once we both ✅, we can merge.

Copy link
Contributor

jsjoeio commented Aug 22, 2022

  1. [Chromium] › extensions.test.ts:8:3 › Extensions › should have access to VSCODE_PROXY_URI =====

We know this test is flakey. #5481 should reduce that a bit.

Copy link
Contributor

jsjoeio commented Aug 22, 2022

All looks good. I did notice a weird flash of the terminal prompt but I don't know if that's related to zsh or my think 🤔 anyone else see this?

Screen.Recording.2022年08月22日.at.10.07.26.AM.mov

Copy link
Member

I am not seeing my prompt doing that (using Bash). My guess is it is either ZSH or the predictive output but probably unrelated to this PR.

Copy link
Member

code-asher commented Aug 22, 2022
edited
Loading

Actually maybe they did change something...when I run ZSH there is a slight flash but not with 4.6.0. Weird.

Copy link
Member

Ah nevermind I see it on 4.6.0 as well, just at a different frequency.

jsjoeio reacted with thumbs up emoji jsjoeio reacted with eyes emoji

@jsjoeio jsjoeio merged commit bc05a2f into coder:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

+1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: Upgrade vscode to 1.70.2

AltStyle によって変換されたページ (->オリジナル) /