-
Notifications
You must be signed in to change notification settings - Fork 6.3k
chore(ci): fix when npm job runs #5440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
code-asher
approved these changes
Aug 10, 2022
Codecov Report
Merging #5440 (b93e18d) into main (6d8f30d) will not change coverage.
The diff coverage isn/a
.
@@ Coverage Diff @@ ## main #5440 +/- ## ======================================= Coverage 72.42% 72.42% ======================================= Files 30 30 Lines 1672 1672 Branches 366 366 ======================================= Hits 1211 1211 Misses 398 398 Partials 63 63
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6d8f30d...b93e18d. Read the comment docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Originally, I thought #5429 would fix the issue of the npm job not running on merges into
main
. However, that didn't work. Turns out the action/workflow we were trying to fix is not apull_request
event but instead apush
event.image (1)
Therefore, we modified the logic to run on PRs into
main
(logic unchanged in file) and added logic to run on all other events besidespull_request
. This protects it from running on PRs from forks but also allows it to run onpush
intomain
. We went with this approach instead of explicitly writingmain
in the logic so that it doesn't break if we change the default branch name.Sources
Fixes N/A