Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(ci): fix when npm job runs #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 1 commit into main from jsjoeio/npm-fix-again
Aug 10, 2022
Merged

chore(ci): fix when npm job runs #5440

jsjoeio merged 1 commit into main from jsjoeio/npm-fix-again
Aug 10, 2022

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Aug 10, 2022
edited
Loading

Description

Originally, I thought #5429 would fix the issue of the npm job not running on merges into main. However, that didn't work. Turns out the action/workflow we were trying to fix is not a pull_request event but instead a push event.

image (1)

Therefore, we modified the logic to run on PRs into main (logic unchanged in file) and added logic to run on all other events besides pull_request. This protects it from running on PRs from forks but also allows it to run on push into main. We went with this approach instead of explicitly writing main in the logic so that it doesn't break if we change the default branch name.

Sources

Fixes N/A

@jsjoeio jsjoeio self-assigned this Aug 10, 2022
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Aug 10, 2022
@jsjoeio jsjoeio added this to the August 2022 milestone Aug 10, 2022
@jsjoeio jsjoeio marked this pull request as ready for review August 10, 2022 18:40
@jsjoeio jsjoeio requested a review from a team August 10, 2022 18:40
@jsjoeio jsjoeio temporarily deployed to npm August 10, 2022 18:41 Inactive
Copy link

✨ code-server dev build published to npm for PR #5440!

  • Last publish status: success
  • Commit: b93e18d

To install in a local project, run:

npm install @coder/code-server-pr@5440

To install globally, run:

npm install -g @coder/code-server-pr@5440

Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #5440 (b93e18d) into main (6d8f30d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #5440 +/- ##
=======================================
 Coverage 72.42% 72.42% 
=======================================
 Files 30 30 
 Lines 1672 1672 
 Branches 366 366 
=======================================
 Hits 1211 1211 
 Misses 398 398 
 Partials 63 63 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8f30d...b93e18d. Read the comment docs.

@jsjoeio jsjoeio merged commit 3335d0a into main Aug 10, 2022
@jsjoeio jsjoeio deleted the jsjoeio/npm-fix-again branch August 10, 2022 18:43
@jsjoeio jsjoeio temporarily deployed to npm August 10, 2022 19:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Labels
chore Related to maintenance or clean up
Projects
None yet
Milestone
v4.5.2
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /