Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Revise welcome page #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nol166 wants to merge 3 commits into coder:master from nol166:master
Closed

Revise welcome page #54

nol166 wants to merge 3 commits into coder:master from nol166:master

Conversation

Copy link
Contributor

@nol166 nol166 commented Mar 6, 2019

Add Coder specific links, remove non-working links.

@nol166 nol166 self-assigned this Mar 6, 2019
@nol166 nol166 removed their assignment Mar 6, 2019
"spdlog": path.join(vsFills, "spdlog.ts"),
"native-watchdog": path.join(vsFills, "native-watchdog.ts"),
"iconv-lite": path.join(vsFills, "iconv-lite.ts"),
"welcome": path.join(vsFills, "welcomePage.ts"),
Copy link
Member

@code-asher code-asher Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alias will need to match the import, so in this case vs/workbench/parts/welcome/page/electron-browser/vs_code_welcome_page.

kylecarbs reacted with thumbs up emoji
Copy link
Member

We should be careful about this. Wouldn't want to miss an update on their welcome page. Not sure if theres really a way around that.
MichaelDesantis reacted with thumbs up emoji

Copy link
Member

code-asher commented Mar 6, 2019 •
edited
Loading

Ahh, true, maybe we should patch it after all? I suggested the alias but the updates are definitely a good reason to go with patching.
kylecarbs and MichaelDesantis reacted with thumbs up emoji

Copy link
Contributor

Should we consider using the update modal that we currently have on our hosted version and stick to using that for all coder-related stuff?

Copy link
Contributor Author

nol166 commented Mar 7, 2019

Closing this one. Going to make a patch.

@nol166 nol166 closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher requested changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /