-
Notifications
You must be signed in to change notification settings - Fork 6.3k
#5374 make requirements clear #5375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wonder if we should say vCPU? I see that terminology in Google Cloud and AWS.
Codecov Report
Merging #5375 (849c2e8) into main (0e9ec02) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #5375 +/- ## ======================================= Coverage 72.42% 72.42% ======================================= Files 30 30 Lines 1672 1672 Branches 366 366 ======================================= Hits 1211 1211 Misses 398 398 Partials 63 63
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 0e9ec02...849c2e8. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just marking this PR as changes requested while we talk about the terminology.
Agreed, vCPU makes more sense.
I don't have permission to push to your branch so I'm going to close and open a new PR
Fixes #5374