-
Notifications
You must be signed in to change notification settings - Fork 6.3k
chore(prettier): ignore lib/vscode #5347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using an overrides command in our `.prettierrc.yaml` which quickly became out of sync with Code's Prettier styles. Instead, we simply tell Prettier to ignore `lib/vscode`. This way, if you have `formatOnSave` on and you save inside `lib/vscode`, you won't convert the file to use code-server's styles.
✨ code-server docs for PR #5347 is ready! It will be updated on every commit.
- Host: https://coder.com/docs/code-server/8153a1d
- Last deploy status: success
- Commit: 1f31d3a
- Workflow status: https://github.com/coder/code-server/actions/runs/2679283565
code-asher
code-asher
approved these changes
Jul 15, 2022
Codecov Report
Merging #5347 (1f31d3a) into main (907dd83) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #5347 +/- ## ======================================= Coverage 72.38% 72.38% ======================================= Files 30 30 Lines 1673 1673 Branches 367 367 ======================================= Hits 1211 1211 Misses 399 399 Partials 63 63
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 907dd83...1f31d3a. Read the comment docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using an overrides command in our
.prettierrc.yamlwhichquickly became out of sync with Code's Prettier styles.
Instead, we simply tell Prettier to ignore
lib/vscode.This way, if you have
formatOnSaveon and you save insidelib/vscode, you won't convert the file to use code-server's styles.Fixes #