-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Auto docker building and deploy in travis CI #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lucacasonato
lucacasonato
requested review from
code-asher and
kylecarbs
as code owners
April 17, 2019 22:57
code-asher
pushed a commit
that referenced
this pull request
Sep 17, 2019
* made spacing for travis yaml consistent in file * cleaned up .travis.yml and moved some code into a script * checking if i can get travis to build this * travis * fixed an if statement * fixed travis.yml file * replaced my name with codercom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker images now get built & deployed automatically. Extracting the binary from the docker container (#498 (comment)) doesn't work particularly well (and doesn't work for macOS) so binaries are still built the 'old' way for both macOS and Linux. The Docker image is only built when Travis' OS is Linux.
You will need to add a
DOCKER_USERNAMEandDOCKER_PASSWORDenvironment variable to Travis to enable it to push. It currently just pushes a tag every time you push to master. Docker does not havedraftimages afaikI also cleaned up the
.travis.ymlfile so it uses the same tab spacing everywhere.Fixes #498.