Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

docs: rename master to main in all github doc links #5190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 2 commits into coder:main from F3n67u:fix/doc
May 11, 2022
Merged

Conversation

Copy link
Contributor

@F3n67u F3n67u commented May 11, 2022 •
edited
Loading

This pr:

  1. rename master to main on all github doc links
  2. correct node requirement from 14+ to 16+
  3. correct link to contributing tour

@F3n67u F3n67u requested a review from a team May 11, 2022 02:05
"file": "package.json",
"line": 31,
"description": "## Commands\n\nTo start developing, make sure you have Node 14+ and the [required dependencies](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites) installed. Then, run the following commands:\n\n1. Install dependencies:\n>> yarn\n\n3. Start development mode (and watch for changes):\n>> yarn watch"
"description": "## Commands\n\nTo start developing, make sure you have Node 16+ and the [required dependencies](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites) installed. Then, run the following commands:\n\n1. Install dependencies:\n>> yarn\n\n3. Start development mode (and watch for changes):\n>> yarn watch"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we require node 16+ instead of node 14+ now.

@F3n67u F3n67u changed the title (削除) docs: rename master to main in all github doc links and correct node requirement from 14+ to 16+ (削除ここまで) (追記) docs: rename master to main in all github doc links (追記ここまで) May 11, 2022
"file": "src/node/app.ts",
"line": 62,
"description": "## That's it!\n\n\nThat's all there is to it! When this tour ends, your terminal session may stop, but just use `yarn watch` to start developing from here on out!\n\n\nIf you haven't already, be sure to check out these resources:\n- [Tour: Contributing](command:codetour.startTourByTitle?[\"Contributing\")\n- [Docs: FAQ.md](https://github.com/coder/code-server/blob/master/docs/FAQ.md)\n- [Docs: CONTRIBUTING.md](https://github.com/coder/code-server/blob/master/docs/CONTRIBUTING.md)\n- [Community: GitHub Discussions](https://github.com/coder/code-server/discussions)\n- [Community: Slack](https://community.coder.com)"
"description": "## That's it!\n\n\nThat's all there is to it! When this tour ends, your terminal session may stop, but just use `yarn watch` to start developing from here on out!\n\n\nIf you haven't already, be sure to check out these resources:\n- [Tour: Contributing](command:codetour.startTourByTitle?[\"Contributing\"])\n- [Docs: FAQ.md](https://github.com/coder/code-server/blob/main/docs/FAQ.md)\n- [Docs: CONTRIBUTING.md](https://github.com/coder/code-server/blob/main/docs/CONTRIBUTING.md)\n- [Community: GitHub Discussions](https://github.com/coder/code-server/discussions)\n- [Community: Slack](https://community.coder.com)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a small fix: add a missing ] to the link, from:

[Tour: Contributing](command:codetour.startTourByTitle?[\"Contributing\")

to

[Tour: Contributing](command:codetour.startTourByTitle?[\"Contributing\"])

jsjoeio reacted with hooray emoji
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe we didn't notice this - thank you so much!

F3n67u reacted with heart emoji
@jsjoeio jsjoeio self-assigned this May 11, 2022
@jsjoeio jsjoeio added the docs Documentation related label May 11, 2022
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #5190 (093fe9f) into main (a02f477) will not change coverage.
The diff coverage is n/a.

❗ Current head 093fe9f differs from pull request most recent head 902b2e6. Consider uploading reports for the commit 902b2e6 to get more accurate results

Impacted file tree graph 

@@ Coverage Diff @@
## main #5190 +/- ##
=======================================
 Coverage 71.73% 71.73% 
=======================================
 Files 30 30 
 Lines 1663 1663 
 Branches 367 367 
=======================================
 Hits 1193 1193 
 Misses 403 403 
 Partials 67 67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02f477...902b2e6. Read the comment docs.

@jsjoeio jsjoeio merged commit dedd770 into coder:main May 11, 2022
@F3n67u F3n67u deleted the fix/doc branch May 12, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /