Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: attempt to fix docker #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 3 commits into main from jsjoeio/temp-docker-fix
Apr 15, 2022
Merged

chore: attempt to fix docker #5106

jsjoeio merged 3 commits into main from jsjoeio/temp-docker-fix
Apr 15, 2022

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Apr 14, 2022
edited
Loading

We had an issue publishing v4.0.3 where the action couldn't find the artifacts to download. This changes that flow to download the release assets from the release for the Docker workflow.

@jsjoeio jsjoeio requested a review from a team April 14, 2022 23:20
Copy link

github-actions bot commented Apr 14, 2022
edited
Loading

✨ code-server docs for PR #5106 is ready! It will be updated on every commit.

Copy link

codecov bot commented Apr 14, 2022
edited
Loading

Codecov Report

Merging #5106 (2380941) into main (09fc64a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #5106 +/- ##
=======================================
 Coverage 71.33% 71.33% 
=======================================
 Files 30 30 
 Lines 1685 1685 
 Branches 374 374 
=======================================
 Hits 1202 1202 
 Misses 413 413 
 Partials 70 70 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09fc64a...2380941. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm April 14, 2022 23:25 Inactive
Copy link

github-actions bot commented Apr 14, 2022
edited
Loading

✨ code-server dev build published to npm for PR #5106!

  • Last publish status: success
  • Commit: 2380941

To install in a local project, run:

npm install @coder/code-server-pr@5106

To install globally, run:

npm install -g @coder/code-server-pr@5106

@jsjoeio jsjoeio temporarily deployed to npm April 14, 2022 23:33 Inactive
@code-asher code-asher self-requested a review April 14, 2022 23:38
@jsjoeio jsjoeio temporarily deployed to npm April 14, 2022 23:39 Inactive
@jsjoeio jsjoeio force-pushed the jsjoeio/temp-docker-fix branch from e3b5e72 to 2380941 Compare April 14, 2022 23:40
"package": "./ci/build/build-packages.sh",
"postinstall": "./ci/dev/postinstall.sh",
"publish:npm": "./ci/steps/publish-npm.sh",
"publish:docker": "./ci/steps/docker-buildx-push.sh",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency, i wanted it to be like the publish:npm flow/script.

code-asher reacted with thumbs up emoji
@jsjoeio jsjoeio enabled auto-merge (squash) April 14, 2022 23:43
@jsjoeio jsjoeio self-assigned this Apr 14, 2022
@jsjoeio jsjoeio added ci Issues related to ci chore Related to maintenance or clean up labels Apr 14, 2022
@jsjoeio jsjoeio added this to the April 2022 milestone Apr 14, 2022
@jsjoeio jsjoeio temporarily deployed to npm April 14, 2022 23:45 Inactive
@jsjoeio jsjoeio merged commit dea6a40 into main Apr 15, 2022
@jsjoeio jsjoeio deleted the jsjoeio/temp-docker-fix branch April 15, 2022 00:02
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
* chore: attempt to fix docker
* Update .github/workflows/docker.yaml
Co-authored-by: Asher <ash@coder.com>
* chore: add publish:docker to scripts
Co-authored-by: Asher <ash@coder.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Labels
chore Related to maintenance or clean up ci Issues related to ci
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /