-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix(npm): write npm package name to file #5049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ code-server docs for PR #5049 is ready! It will be updated on every commit.
- Host: https://coder.com/docs/code-server/5361034
- Last deploy status: success
- Commit: 60bcb98
- Workflow status: https://github.com/coder/code-server/actions/runs/2067831613
code-asher
code-asher
approved these changes
Mar 30, 2022
Codecov Report
Merging #5049 (60bcb98) into main (d5d7c51) will not change coverage.
The diff coverage isn/a
.
@@ Coverage Diff @@ ## main #5049 +/- ## ======================================= Coverage 71.30% 71.30% ======================================= Files 30 30 Lines 1683 1683 Branches 373 373 ======================================= Hits 1200 1200 Misses 413 413 Partials 70 70
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d5d7c51...60bcb98. Read the comment docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally removed the part that writes the
jq
change to thepackage.json
which means we weren't actually publishing to@coder/code-server-pr
. Oops.Fixes N/A