-
Notifications
You must be signed in to change notification settings - Fork 6.3k
refactor(brew-bump): fix homebrew bump script #5025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ code-server docs for PR #5025 is ready! It will be updated on every commit.
- Host: https://coder.com/docs/code-server/17e1c71
- Last deploy status: success
- Commit: aca716d
- Workflow status: https://github.com/coder/code-server/actions/runs/2061680038
Codecov Report
Merging #5025 (aca716d) into main (18e19d2) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #5025 +/- ## ======================================= Coverage 71.30% 71.30% ======================================= Files 30 30 Lines 1683 1683 Branches 373 373 ======================================= Hits 1200 1200 Misses 413 413 Partials 70 70
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 18e19d2...aca716d. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Homebrew runs on Linux and Linux runners are more available (anecdotally) than macOS runners. Maybe it'll save some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure if I should use a real email or a fake one. Opted for a legit one in case something happened with this PR and someone needed to contact us 🤷🏼♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this comment, using that setup homebrew action means we shouldn't have to keep a fork up-to-date and in testing things, it worked.
And to confirm, you can see in the PR description that brew bump-formula-pr with --dry-run worked even though cdrci's fork is behind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great news! I guess the issue we ran into was an edge case.
This reverts commit 2f7a361.
bump @code-asher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great news! I guess the issue we ran into was an edge case.
* fix: source lib.sh in docker-buildx-push for tagging version * chore: use ubuntu and update git config homebrew job * refactor: simplify brew-bump.sh script * Revert "fix: source lib.sh in docker-buildx-push for tagging version" This reverts commit 2f7a361.
This PR should fix the
brew-bumpscript that runs when we publish releases.Testing
I tested this in a separate PR with the
--dry-runflag and received no errors. I didn't try without--dry-runbut can separately if requested.Here is how I tested: https://github.com/coder/code-server/pull/5023/files
Fixes #4950