-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat: add tests for update.ts #4835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ Coder.com for PR #4835 deployed! It will be updated on every commit.
- Host: https://codercom-p9amhrkwr-codercom.vercel.app/docs/code-server
- Last deploy status: success
- Commit: 99db1b7
- Workflow status: https://github.com/coder/code-server/actions/runs/1831444900
Codecov Report
@@ Coverage Diff @@ ## main #4835 +/- ## ========================================== + Coverage 69.17% 69.72% +0.54% ========================================== Files 29 29 Lines 1645 1645 Branches 363 363 ========================================== + Hits 1138 1147 +9 + Misses 430 424 -6 + Partials 77 74 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! All my comments are questions/optional except for the redirect that seems to increment instead of decrement.
bump @code-asher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful fixup commits, very easy to re-review. <3
613093b to
99db1b7
Compare
* feat: add isAddressInfo helper function * feat(update): add test for rejection UpdateProvider * feat: add more tests for UpdateProvider * fixup! move isAddressInfo, add .address check * fixup! remove extra writeHead * fixup! use -1 in redirect logic * fixup! remove unnecessary String call * fixup! use /latest for redirect * fixup! use match group for regex * fixup!: replace match/split logic
This PR adds more tests for
update.ts.Fixes #4831