-
Notifications
You must be signed in to change notification settings - Fork 6.3k
refactor(ci): clean up npm workflows #4786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extracst the publish on npm workflow from ci.yaml and adds a new workflow called `npm-beta.yaml`. Now we have three workflows that publish to npm. - `npm-beta.yaml` only runs on pushes and merges into `main` - `npm-dev.yaml` only runs on PRs into `main` with approval from code-server-reviewers team - `npm-brew.yaml` only runs on releases This should fix problems we had previously where anyone could open a PR and publish under the code-server namespace. It also separates out the workflows based on environment and when they should run.
@jsjoeio
jsjoeio
added
ci
Issues related to ci
chore
Related to maintenance or clean up
labels
Jan 24, 2022
✨ Coder.com for PR #4786 deployed! It will be updated on every commit.
- Host: https://codercom-p3bvxg405-codercom.vercel.app/docs/code-server
- Last deploy status: success
- Commit: c7d69bb
- Workflow status: https://github.com/coder/code-server/actions/runs/1742404204
Codecov Report
Merging #4786 (c7d69bb) into main (48bbbd6) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #4786 +/- ## ======================================= Coverage 69.18% 69.18% ======================================= Files 29 29 Lines 1652 1652 Branches 363 363 ======================================= Hits 1143 1143 Misses 432 432 Partials 77 77
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 48bbbd6...c7d69bb. Read the comment docs.
code-asher
code-asher
approved these changes
Jan 24, 2022
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
This extracst the publish on npm workflow from ci.yaml and adds a new workflow called `npm-beta.yaml`. Now we have three workflows that publish to npm. - `npm-beta.yaml` only runs on pushes and merges into `main` - `npm-dev.yaml` only runs on PRs into `main` with approval from code-server-reviewers team - `npm-brew.yaml` only runs on releases This should fix problems we had previously where anyone could open a PR and publish under the code-server namespace. It also separates out the workflows based on environment and when they should run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This extracts the publish on npm workflow from ci.yaml and adds a new workflow
called
npm-beta.yaml.Now we have three workflows that publish to npm.
npm-beta.yamlonly runs on pushes and merges intomainnpm-dev.yamlonly runs on PRs intomainwith approval fromcode-server-reviewers team
npm-brew.yamlonly runs on releasesThis should fix problems we had previously where anyone could open a PR and
publish under the code-server namespace. It also separates out the workflows
based on environment and when they should run.
I've also added the Environment
npmwhich requires approval from one member of the code-server-reviewers team in order to run. This allows us to control which PRs publish to npm.Fixes N/A
Fixes this issue: https://github.com/coder/code-server/runs/4903326846?check_suite_focus=true#step:14:13