-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat: add tests for node/settings.ts #4717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## main #4717 +/- ## ========================================== + Coverage 69.10% 69.23% +0.12% ========================================== Files 29 29 Lines 1638 1638 Branches 341 341 ========================================== + Hits 1132 1134 +2 + Misses 430 428 -2 Partials 76 76
Continue to review full report at Codecov.
|
792134e to
386bf29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I only have architectural comments.
✨ Coder.com for PR #4717 deployed! It will be updated on every commit.
- Host: https://codercom-pzljzqora-codercom.vercel.app/docs/code-server
- Last deploy status: success
- Commit: 7000239
- Workflow status: https://github.com/coder/code-server/actions/runs/1679306105
386bf29 to
7000239
Compare
Uh oh!
There was an error while loading. Please reload this page.
This PR adds additional tests for
node/settings.tsto ensure we log warnings when expected.Context
The
SettingsProviderprovides the application with access to the settings for code-server. This is then added to all routes underreq.settingsso they can easily access it. We're adding tests to ensure that our logger does indeed log warnings when something goes wrong.Screenshots
Before
image
After
image
Fixes N/A
#TestingMondays