Skip to content

fix(package.json): update node version requirements to >=14 #4230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

GirlBossRush merged 1 commit into coder:main from AbdullahBinJahed:patch-1

Sep 24, 2021

Merged

fix(package.json): update node version requirements to >=14 #4230

GirlBossRush merged 1 commit into coder:main from AbdullahBinJahed:patch-1

Sep 24, 2021

Conversation

AbdullahBinJahed

Copy link

Contributor

@AbdullahBinJahed AbdullahBinJahed commented Sep 23, 2021 •

edited by jsjoeio

Loading

Fixes #4225

@AbdullahBinJahed


 Update package.json

b8dcafc

@AbdullahBinJahed AbdullahBinJahed requested a review from a team as a code owner

September 23, 2021 17:38

@GirlBossRush GirlBossRush enabled auto-merge (rebase)

September 23, 2021 19:13

@GirlBossRush GirlBossRush self-assigned this

@GirlBossRush GirlBossRush added the javascript label

Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #4230 (b8dcafc) into main (ed09268) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #4230 +/- ##
=======================================
 Coverage 65.09% 65.09% 
=======================================
 Files 36 36 
 Lines 1882 1882 
 Branches 380 380 
=======================================
 Hits 1225 1225 
 Misses 559 559 
 Partials 98 98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed09268...b8dcafc. Read the comment docs.

@jsjoeio jsjoeio changed the title ~~(削除) node version 14 to node version 14 or greater in package.json (削除ここまで)~~ (追記) fix(package.json): update node version requirements to >=14 (追記ここまで)

GirlBossRush approved these changes

View reviewed changes

@GirlBossRush GirlBossRush merged commit c11d51e into coder:main

@AbdullahBinJahed

Copy link

Contributor Author

AbdullahBinJahed commented Sep 25, 2021

hey, why it's still not working ?

Copy link

Contributor

jsjoeio commented Sep 27, 2021

@AbdullahBinJahed this was merged, but it won't be available until we release 3.12.1

@jsjoeio jsjoeio mentioned this pull request

Uninstallable under Termux due to node version #4250

Closed

@AbdullahBinJahed

Copy link

Contributor Author

AbdullahBinJahed commented Sep 27, 2021

@AbdullahBinJahed this was merged, but it won't be available until we release 3.12.1

hmm yeah already noticed right after commenting here but still thanks for telling me

@jawnsy jawnsy mentioned this pull request

Determine Node.js version pinning policy #4258

Closed

@amiria703 amiria703 mentioned this pull request

Can't install code-server 3.12.1 #4618

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@AbdullahBinJahed @jsjoeio @GirlBossRush