-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix: comment out broken e2e test #4175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Merging #4175 (b7c9712) into main (b37ff28) will not change coverage.
The diff coverage isn/a
.
❗ Current head b7c9712 differs from pull request most recent head 2221441. Consider uploading reports for the commit 2221441 to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #4175 +/- ## ======================================= Coverage 64.22% 64.22% ======================================= Files 36 36 Lines 1873 1873 Branches 379 379 ======================================= Hits 1203 1203 Misses 569 569 Partials 101 101
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b37ff28...2221441. Read the comment docs.
✨ Coder.com for PR #4175 deployed! It will be updated on every commit.
- Host: https://codercom-mogb2sz8l-codercom.vercel.app/docs/code-server
- Last deploy status: success
- Commit: 2221441
- Workflow status: https://github.com/cdr/code-server/actions/runs/1243163643
1780da2
to
2221441
Compare
@jsjoeio I believe upstream made some changes to how they create menus, and it’s possible that our test isn’t accurately targeting the menu entry. Could we move the test to vscode’s suite?
Uh oh!
There was an error while loading. Please reload this page.
The main purpose of this PR is to get the assets from CI so we can update code-server on Docker.
I've run e2e tests twice and they keep failing. Maybe we removed the Log out button when we updated VS Code? cc @TeffenEllis
I'm going to disable those tests for now.