-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add linkup command to improve link functionality #4171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4fdd243 to
0a3b3a3
Compare
✨ Coder.com for PR #4171 deployed! It will be updated on every commit.
- Host: https://codercom-g5oimt3mj-codercom.vercel.app/docs/code-server
- Last deploy status: success
- Commit: bdca804
- Workflow status: https://github.com/cdr/code-server/actions/runs/1254636225
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all looks good but probably want a second opinion from @kylecarbs (plus CI is failing)
error Your lockfile needs to be updated, but yarn was run with
--frozen-lockfile.
Do we need to update the yarn.lock file?
0a3b3a3 to
bdca804
Compare
Codecov Report
@@ Coverage Diff @@ ## main #4171 +/- ## ========================================== + Coverage 64.22% 65.17% +0.94% ========================================== Files 36 37 +1 Lines 1873 1898 +25 Branches 379 382 +3 ========================================== + Hits 1203 1237 +34 + Misses 569 562 -7 + Partials 101 99 -2
Continue to review full report at Codecov.
|
This PR likely needs to be rebased and updated with the latest vscode commit
I wasn't sure what you meant by "updated with the latest vscode commit":
Option 1
- go to https://github.com/cdr/vscode
- hit Fetch upstream
- grab the latest vscode commit
- use that in
vendor/package.json
Option 2
- go to https://github.com/cdr/vscode
- grab the latest vscode commit:
affcb6753278c014d1eea83664e6fbf5d702852a - use that in
vendor/package.json
Option 3.
- look at
mainbranch in code-server - use vscode commit in
vendor/package.json
I rebased and went with Option 3: 9cb5fb3759f46b10bc66e676fa7f44c51e84824b
I hope that's right. I'll wait for you to check before we merge this.
Tentatively resolved in #4010
TBD