-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix(codecov): use status > patch correctly #4159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Merging #4159 (030f657) into main (bc3acb0) will not change coverage.
The diff coverage isn/a.
❗ Current head 030f657 differs from pull request most recent head 14c9616. Consider uploading reports for the commit 14c9616 to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #4159 +/- ## ======================================= Coverage 64.22% 64.22% ======================================= Files 36 36 Lines 1873 1873 Branches 379 379 ======================================= Hits 1203 1203 Misses 569 569 Partials 101 101
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update bc3acb0...14c9616. Read the comment docs.
✨ Coder.com for PR #4159 deployed! It will be updated on every commit.
- Host: https://codercom-gtbv2m4l9-codercom.vercel.app/docs/code-server
- Last deploy status: success
- Commit: 14c9616
- Workflow status: https://github.com/cdr/code-server/actions/runs/1231195199
@bryphe-coder
bryphe-coder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me! 👍
I thought I fixed this in a previous PR but I guess not. I can't seem to find it. Turns out, our codecov was technically invalid because we weren't using
patch: offunderstatus.To prevent this in the future, validate the codecov:
Fixes N/A