-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Push latest Docker tag along with version tag #4120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Merging #4120 (0601561) into main (b00afbc) will not change coverage.
The diff coverage isn/a.
❗ Current head 0601561 differs from pull request most recent head b4df05f. Consider uploading reports for the commit b4df05f to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #4120 +/- ## ======================================= Coverage 64.12% 64.12% ======================================= Files 36 36 Lines 1873 1873 Branches 379 379 ======================================= Hits 1201 1201 Misses 571 571 Partials 101 101
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update b00afbc...b4df05f. Read the comment docs.
@jawnsy
jawnsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me
@jawnsy
jawnsy
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this doesn't seem like it'd work correctly in the case where we're trying to re-build an old version (not sure if we ever do that though) since latest would move "backwards"
Seems we'd need some way to check the "current" latest version and compare before we update the tag, to make that work correctly
I guess this seems like a decent enough solution 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be covered by the check here, more as a side effect though and only for versions already uploaded:
We could add a check here to see if it is greater than the latest version available and only then add latest (through a second env var I think).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw this does bring us back to what we had before we switched to buildx (always push to latest)
@jawnsy
jawnsy
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, don't let me stand in your way! 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made an issue: #4121 Thanks for the suggestion!
Uh oh!
There was an error while loading. Please reload this page.
#3920 (comment)
https://docs.docker.com/engine/reference/commandline/buildx_bake/