Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

#4113 compile extensions media #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 1 commit into coder:main from sdissegna-maystreet:compile-ext-media
Sep 7, 2021

Conversation

Copy link
Contributor

@sdissegna-maystreet sdissegna-maystreet commented Sep 7, 2021

Fixes #4113

bpmct reacted with thumbs up emoji
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #4114 (59507be) into main (d26858b) will increase coverage by 0.60%.
The diff coverage is 100.00%.

❗ Current head 59507be differs from pull request most recent head 622c7d1. Consider uploading reports for the commit 622c7d1 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## main #4114 +/- ##
==========================================
+ Coverage 63.51% 64.12% +0.60% 
==========================================
 Files 36 36 
 Lines 1872 1873 +1 
 Branches 379 379 
==========================================
+ Hits 1189 1201 +12 
+ Misses 580 571 -9 
+ Partials 103 101 -2 
Impacted Files Coverage Δ
src/browser/pages/vscode.ts 100.00% <100.00%> (+16.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26858b...622c7d1. Read the comment docs.

Copy link
Contributor

@GirlBossRush GirlBossRush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I believe we ran into this same issue in #4010

Copy link
Contributor

jsjoeio commented Sep 7, 2021

The Docs preview failing is unrelated to your change so you can ignore.

The Build / Run audit-ci failing is due to a tar vulnerability which I fixed as part of #4071 so you should be good there. I will do a "Rebase and merge".

Thanks so much for fixing this @sdissegna-maystreet 🙌

@jsjoeio jsjoeio merged commit 0529f52 into coder:main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@GirlBossRush GirlBossRush GirlBossRush approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extensions media files not compiled in release

AltStyle によって変換されたページ (->オリジナル) /