-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add serviceworker + Monaco Service Worker #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this add web workers or does it add service workers? AFAIK Monaco uses web workers rather than service workers, because Monaco doesn't have to do background processing, rather it does parallel processing. If this is the case this should not be merged together with the "Service worker and PWA" PR as it is not related.
You might be confused by Monaco's "language server service" workers, which are not service workers but rather just regular web workers which are running a "language server service". (https://www.quora.com/Whats-the-difference-between-service-workers-and-web-workers-in-JavaScript)
@creativeguy2013 you are right 👍
Uh oh!
There was an error while loading. Please reload this page.
#154 original PR, rebased and fixed conflicts
Describe in detail the problem you had and how this PR fixes it
Also added monaco webpack plugin which enables monaco to operate via the service worker.
Is there an open issue you can link to?
#375