Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add serviceworker + Monaco Service Worker #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreimc wants to merge 10 commits into coder:master from andreimc:master
Closed

Add serviceworker + Monaco Service Worker #411

andreimc wants to merge 10 commits into coder:master from andreimc:master

Conversation

Copy link

@andreimc andreimc commented Apr 3, 2019
edited
Loading

#154 original PR, rebased and fixed conflicts

Describe in detail the problem you had and how this PR fixes it

Also added monaco webpack plugin which enables monaco to operate via the service worker.

Is there an open issue you can link to?

#375

Copy link
Contributor

Does this add web workers or does it add service workers? AFAIK Monaco uses web workers rather than service workers, because Monaco doesn't have to do background processing, rather it does parallel processing. If this is the case this should not be merged together with the "Service worker and PWA" PR as it is not related.

You might be confused by Monaco's "language server service" workers, which are not service workers but rather just regular web workers which are running a "language server service". (https://www.quora.com/Whats-the-difference-between-service-workers-and-web-workers-in-JavaScript)

Copy link
Author

andreimc commented Apr 3, 2019

@creativeguy2013 you are right 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher Awaiting requested review from code-asher

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /