-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Resolve remote authority to initialize tunnel API #4105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ Coder.com for PR #4105 deployed! It will be updated on every commit.
- Host: https://codercom-720h90dww-codercom.vercel.app/docs/code-server
- Last deploy status: success
- Commit: c7a5263
- Workflow status: https://github.com/cdr/code-server/actions/runs/1214177762
Codecov Report
Merging #4105 (476b9c5) into main (67b23aa) will not change coverage.
The diff coverage isn/a.
❗ Current head 476b9c5 differs from pull request most recent head c7a5263. Consider uploading reports for the commit c7a5263 to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #4105 +/- ## ======================================= Coverage 64.12% 64.12% ======================================= Files 36 36 Lines 1873 1873 Branches 379 379 ======================================= Hits 1201 1201 Misses 571 571 Partials 101 101
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 67b23aa...c7a5263. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing and I don't see how this would break anything.
Nice comments too 🚀
Uh oh!
There was an error while loading. Please reload this page.
This enables the
vscode.workspace.registerRemoteAuthorityResolverAPI to be executed.It's specifically scoped to the "coder-link" scheme at the moment to reduce external dependency on forking VS Code functionality.
The remote host doesn't resolve to an extension host like the API expects, but instead we only utilize the tunnel functionality.