-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Protocol cleanup WIP #4053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Protocol cleanup WIP #4053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@GirlBossRush
GirlBossRush
added
bug
Something isn't working
enhancement
Some improvement that isn't a feature
labels
Aug 27, 2021
@GirlBossRush
GirlBossRush
changed the base branch from
main
to
3835-lib-partial-upgrade
August 27, 2021 20:58
✨ Coder.com for PR #4053 deployed! It will be updated on every commit.
- Host: https://codercom-impt8qfdm-codercom.vercel.app/docs/code-server
- Last deploy status: success
- Commit: 79418c5
- Workflow status: https://github.com/cdr/code-server/actions/runs/1175624515
@GirlBossRush
GirlBossRush
force-pushed
the
3835-protocol-cleanup
branch
7 times, most recently
from
September 3, 2021 23:29
63ee582 to
7ced095
Compare
@GirlBossRush
GirlBossRush
force-pushed
the
3835-protocol-cleanup
branch
from
September 3, 2021 23:54
7ced095 to
75e6f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
WIP
This PR continues the cleanups introduced in #4010
Entry point, where code-server and vscode meet (A bit like oil and water)
https://github.com/cdr/code-server/blob/3835-protocol-cleanup/lib/vscode/src/vs/server/entry.ts
Main Server Process
https://github.com/cdr/code-server/blob/3835-protocol-cleanup/lib/vscode/src/vs/server/main.ts
Environment Service
https://github.com/cdr/code-server/blob/3835-protocol-cleanup/lib/vscode/src/vs/server/environmentService.ts
WebSocket Handler
https://github.com/cdr/code-server/blob/3835-protocol-cleanup/lib/vscode/src/vs/server/connection/webSocketHandler.ts
TBD