Codecov Report

Merging #4044 (7a14127) into main (1d4ffda) will not change coverage.
The diff coverage is n/a.

❗ Current head 7a14127 differs from pull request most recent head d650894. Consider uploading reports for the commit d650894 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## main #4044 +/- ##
=======================================
 Coverage 64.22% 64.22% 
=======================================
 Files 36 36 
 Lines 1873 1873 
 Branches 379 379 
=======================================
 Hits 1203 1203 
 Misses 569 569 
 Partials 101 101 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4ffda...d650894. Read the comment docs.

✨ Coder.com for PR #4044 deployed! It will be updated on every commit.

• Host: https://codercom-c000cjqqv-codercom.vercel.app/docs/code-server
• Last deploy status: success
• Commit: d650894
• Workflow status: https://github.com/cdr/code-server/actions/runs/1231263173

Note to self: we think this is caused by handlerbars (in the markdown parsing used on coder com ). Going to leave this open for now and address once we fix upstream

@jsjoeio I added table support on this PR https://github.com/cdr/m/pull/9700, but I noticed a few things:

• TL;DR is a title, and it is being displayed on the table of content. Can we remove that or add a more "descriptive" title like "Usage" or "Quick usage"? Idk if having TL;DR is acceptable. Maybe it is just a personal preference.
• The description field on the table is empty. Maybe it is better to remove the column.

@jsjoeio I wrapped the badges in links like GH does so they are displayed inline. GH code screenshot:
Screen Shot 2021年08月25日 at 18 54 52

TL;DR is a title, and it is being displayed on the table of content. Can we remove that or add a more "descriptive" title like "Usage" or "Quick usage"? Idk if having TL;DR is acceptable. Maybe it is just a personal preference.

Sure! I just copied this over so I have no preference

The description field on the table is empty. Maybe it is better to remove the column.

Hmm...I'm going to ask @jawnsy about that because there may be a reason we need to keep it

Hmmm...something is not right here

https://codercom-enql9v6o6-codercom.vercel.app/docs/code-server/latest

image

@jsjoeio I checked the Inspect page (link shows up in the build/deploy output), it still shows that there's something wrong with the curly braces {} -- @bpmct did you merge the handlebars removal change?

[GET] /docs/code-server/latest
14:03:57:09
info - Building code-server/latest
info - Value of CODE_SERVER_DOCS_MAIN_BRANCH is "ce0c2cd0268a2090e903a8047dfd063bd6c75763".
info - Using "ce0c2cd0268a2090e903a8047dfd063bd6c75763" as main content source.
2021年09月03日T21:03:57.761Z	7bff6c39-d6eb-4178-bdf3-530514c888ca	ERROR	Error: Parse error on line 285:
...ation image: {{ .Values.image.reposi
----------------------^
Expecting 'ID', 'STRING', 'NUMBER', 'BOOLEAN', 'UNDEFINED', 'NULL', 'DATA', got 'SEP'
 at Parser.parseError (/var/task/product/coder.com/site/node_modules/handlebars/dist/cjs/handlebars/compiler/parser.js:267:19)
 at Parser.parse (/var/task/product/coder.com/site/node_modules/handlebars/dist/cjs/handlebars/compiler/parser.js:336:30)
 at parseWithoutProcessing (/var/task/product/coder.com/site/node_modules/handlebars/dist/cjs/handlebars/compiler/base.js:46:33)
 at HandlebarsEnvironment.parse (/var/task/product/coder.com/site/node_modules/handlebars/dist/cjs/handlebars/compiler/base.js:52:13)
 at compileInput (/var/task/product/coder.com/site/node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:508:19)
 at ret (/var/task/product/coder.com/site/node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:517:18)
 at markdownParser (/var/task/product/coder.com/site/.next/server/pages/docs/[[...slug]].js:1538:54)
 at runMicrotasks (<anonymous>)
 at processTicksAndRejections (internal/process/task_queues.js:97:5)
 at async /var/task/product/coder.com/site/.next/server/pages/docs/[[...slug]].js:6788:23
RequestId: 7bff6c39-d6eb-4178-bdf3-530514c888ca Error: Runtime exited with error: exit status 1
Runtime.ExitError

doesn't look like it 😢

https://github.com/cdr/m/pull/9696

Taking a look at why the check returns an error but the action is returning green.

I re-run the check job and now it is working. Idk if it was using an old version of the script 🤔

I re-run the check job and now it is working. Idk if it was using an old version of the script 🤔

🤷‍♂️ I'll keep an eye out.

@BrunoQuaresma can we merge https://github.com/cdr/m/pull/9696?

@jsjoeio yeap! That is good for me.

I need to double-check this branch. I think I messed it up yesterday when I thought I was on another branch.

Looks like it's all working now!

image