Codecov Report

Merging #4020 (1982025) into main (7cde11e) will not change coverage.
The diff coverage is n/a.

❗ Current head 1982025 differs from pull request most recent head e52248a. Consider uploading reports for the commit e52248a to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## main #4020 +/- ##
=======================================
 Coverage 63.51% 63.51% 
=======================================
 Files 36 36 
 Lines 1872 1872 
 Branches 379 379 
=======================================
 Hits 1189 1189 
 Misses 580 580 
 Partials 103 103 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cde11e...e52248a. Read the comment docs.

I'm not sure why Docs preview failed 🤔 Re-running the other failed jobs too. Should be fine though!

@jsjoeio It's probably because I'm doing this from a fork, if I can't get it into a good state then I'll push it as a branch instead - I wanted to use the same workflow that our external contributors would use, as I think that is an important use case for us to support

@jsjoeio It's probably because I'm doing this from a fork, if I can't get it into a good state then I'll push it as a branch instead - I wanted to use the same workflow that our external contributors would use, as I think that is an important use case for us to support

Love that you're making sure we dogfood that workflow! I'm seeing this:

image

cc @BrunoQuaresma is there any reason this workflow doesn't work for forks? Is it because m is private? I'm not fully sure how this should work 🤔

@jsjoeio I think it is because of that since forks don't have access to our internal secrets.

Ah, I think we have to configure this for our secrets: https://docs.github.com/en/actions/reference/environments

Not worth doing right now though, I didn't change docs so I think this is safe to merge 🤞