-
Notifications
You must be signed in to change notification settings - Fork 6.3k
release: 3.11.2 #3940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 3.11.2 #3940
Conversation
Codecov Report
Merging #3940 (90f6330) into main (cde28a0) will not change coverage.
The diff coverage isn/a.
❗ Current head 90f6330 differs from pull request most recent head 734a9a1. Consider uploading reports for the commit 734a9a1 to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #3940 +/- ## ======================================= Coverage 63.51% 63.51% ======================================= Files 36 36 Lines 1872 1872 Branches 379 379 ======================================= Hits 1189 1189 Misses 580 580 Partials 103 103
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update cde28a0...734a9a1. Read the comment docs.
@jawnsy
jawnsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Heads-up. I am moving back to draft because I'm seeing the ripgrep error. I think this is a direct result of the symlink removal. I'm not sure why it didn't show up in the PR where we removed it while testing. I think I'll check-in with @code-asher tomorrow
ERR spawn /Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/node_modules/vscode-ripgrep/bin/rg ENOENT: Error: spawn /Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/node_modules/vscode-ripgrep/bin/rg ENOENT at Object.M [as deserializeSearchError] (http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2000:5630) at http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2003:5041 at async http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2003:3078 at async li.getFileSearchResults (http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2478:11248) at async Promise.all (index 0) at async li.doFileSearch (http://localhost:8080/static/90f633006e1edd78423a1ddc6e9651396c83edca/Users/jp/Dev/code-server/release-packages/code-server-3.11.2-macos-amd64/lib/vscode/out/vs/workbench/workbench.web.api.js:2478:10892)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL will break as per #3953
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't really comment on the correct line - I mean L58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh! Nice catch! (And thanks for your other PR!)
As an extra, I'd suggest using the latest path rather than a specific version
Yes, this is a great idea and I should probably change that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to do in a follow-up PR since I'm closing this: #3963
Uh oh!
There was an error while loading. Please reload this page.
This PR is to generate a new release of
code-serverat3.11.2.Notes: we're publishing this because we had a hiccup releasing
3.11.1to npm.Screenshot
Screen.Recording.2021年08月09日.at.4.07.39.PM.mov
TODOs
Follow "Publishing a release" steps in
ci/README.md