-
Notifications
You must be signed in to change notification settings - Fork 6.3k
chore: fix docs version to only use latest #3934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Merging #3934 (84d11a4) into main (fb11766) will not change coverage.
The diff coverage isn/a.
❗ Current head 84d11a4 differs from pull request most recent head b22ebd8. Consider uploading reports for the commit b22ebd8 to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #3934 +/- ## ======================================= Coverage 63.51% 63.51% ======================================= Files 36 36 Lines 1872 1872 Branches 379 379 ======================================= Hits 1189 1189 Misses 580 580 Partials 103 103
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update fb11766...b22ebd8. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the
manifest.jsonto only include the latest version in theversionskey.Originally, I was going to go with Bruno's suggestion of
v3.11.*to include all patches but as Jonathan noted, we really only need to support the latest version in the docs (we don't have that many changes between versions).Plus, using the specific version like
v3.11.1means it will auto-update with yourrelease-prepscript. Usingv3.11.*would make it more difficult.Fixes #3903 (comment)