-
Notifications
You must be signed in to change notification settings - Fork 6.3k
chore: update guides.md header to Accessing Web Services #3819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
99775ba to
9d6a154
Compare
Codecov Report
Merging #3819 (9d6a154) into main (475ae45) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #3819 +/- ## ======================================= Coverage 62.05% 62.05% ======================================= Files 36 36 Lines 1863 1863 Branches 378 378 ======================================= Hits 1156 1156 Misses 601 601 Partials 106 106
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 475ae45...9d6a154. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for fixing this @khorne3 🎉
oops @jsjoeio not sure if that merged to the right place; please let me know if I need to revert so we can fix
@khorne3 i'll let you decide. before it was in FAQ, now you have it in Guide. Totally up to you!
@jsjoeio ah sorry for the confusion; I just saw that you added it to 3.12.0 milestone and wasn't sure if this is ok to go into main?
Oh! It's okay to go into main. 3.11 was already released so that's why I added it to 3.12. We use the milestones to associate issues/PRs that were done in that cycle. Sorry for the confusion!
Fixes header on guides.md so that it reads "Accessing Web Services" instead of "Self signed certificates." Also updates in-text mention from "web service" to "web services."