Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(docs): clean up and restructure #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khorne3 merged 1 commit into main from docs-edits
Jul 12, 2021
Merged

refactor(docs): clean up and restructure #3756

khorne3 merged 1 commit into main from docs-edits
Jul 12, 2021

Conversation

Copy link
Contributor

@khorne3 khorne3 commented Jul 9, 2021

Edits, minor refactoring of code-server docs.

Copy link

codecov bot commented Jul 9, 2021
edited
Loading

Codecov Report

Merging #3756 (80b5c16) into main (a96e16e) will not change coverage.
The diff coverage is n/a.

❗ Current head 80b5c16 differs from pull request most recent head 66b6590. Consider uploading reports for the commit 66b6590 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## main #3756 +/- ##
=======================================
 Coverage 62.01% 62.01% 
=======================================
 Files 35 35 
 Lines 1835 1835 
 Branches 370 370 
=======================================
 Hits 1138 1138 
 Misses 588 588 
 Partials 109 109 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96e16e...66b6590. Read the comment docs.

@khorne3 khorne3 marked this pull request as ready for review July 12, 2021 16:35
@khorne3 khorne3 requested a review from a team as a code owner July 12, 2021 16:35
@jsjoeio jsjoeio added the docs Documentation related label Jul 12, 2021
@jsjoeio jsjoeio added this to the 3.11.0 milestone Jul 12, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thanks for doing this work @khorne3

Mostly questions/nits for consistency.

Other request: do you mind squashing your commits into one and using a semantic commit? e.g. "refactor(docs): clean up and restructure

khorne3 reacted with thumbs up emoji
@khorne3 khorne3 changed the title (削除) Edit, refactor docs (削除ここまで) (追記) refactor(docs): clean up and restructure (追記ここまで) Jul 12, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock! Thanks again for doing this! I'll approve, feel free to merge when ready!

Han solo saying yahoo

@khorne3 khorne3 merged commit c145008 into main Jul 12, 2021
@khorne3 khorne3 deleted the docs-edits branch July 12, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docs Documentation related
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /