-
Notifications
You must be signed in to change notification settings - Fork 6.3k
refactor(docs): clean up and restructure #3756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Merging #3756 (80b5c16) into main (a96e16e) will not change coverage.
The diff coverage isn/a
.
❗ Current head 80b5c16 differs from pull request most recent head 66b6590. Consider uploading reports for the commit 66b6590 to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #3756 +/- ## ======================================= Coverage 62.01% 62.01% ======================================= Files 35 35 Lines 1835 1835 Branches 370 370 ======================================= Hits 1138 1138 Misses 588 588 Partials 109 109
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a96e16e...66b6590. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! Thanks for doing this work @khorne3
Mostly questions/nits for consistency.
Other request: do you mind squashing your commits into one and using a semantic commit? e.g. "refactor(docs): clean up and restructure
fd5f5ae
to
0c0a221
Compare
0c0a221
to
66b6590
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You rock! Thanks again for doing this! I'll approve, feel free to merge when ready!
Edits, minor refactoring of code-server docs.