-
Notifications
You must be signed in to change notification settings - Fork 6.2k
docs(CONTRIBUTING): add section on testing #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d93f7ff
to
d6bc68a
Compare
Codecov Report
Merging #3629 (787d8d5) into main (5f7e9b7) will not change coverage.
The diff coverage isn/a
.
❗ Current head 787d8d5 differs from pull request most recent head d9bb1a3. Consider uploading reports for the commit d9bb1a3 to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #3629 +/- ## ======================================= Coverage 60.67% 60.67% ======================================= Files 35 35 Lines 1790 1790 Branches 404 404 ======================================= Hits 1086 1086 Misses 562 562 Partials 142 142
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5f7e9b7...d9bb1a3. Read the comment docs.
@jawnsy
jawnsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow!! 🔥 🔥 🔥
I love this, great pointers to help new contributors navigate the codebase and understand how things work
I am strongly in favor of of the 3 test levels, but I miss a definition of the definition and objective of each level. E.g. integration testing could be seen as the interface to to VScode.
but I miss a definition of the definition and objective of each level. E.g. integration testing could be seen as the interface to to VScode
Great feedback! I think I should clarify this a bit more on what we mean by each.
787d8d5
to
5dd9e6f
Compare
5dd9e6f
to
d9bb1a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sweet! Thanks for the reviews @janiversen @jawnsy - going to merge
Uh oh!
There was an error while loading. Please reload this page.
Checklist
CHANGELOG.md