Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Check version #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nol166 wants to merge 25 commits into master from check-version
Closed

Check version #362

nol166 wants to merge 25 commits into master from check-version

Conversation

Copy link
Contributor

@nol166 nol166 commented Mar 27, 2019 •
edited by code-asher
Loading

Describe in detail the problem you had and how this PR fixes it

Checks to see if there is a newer release available when running the CLI

Is there an open issue you can link to?

Fixes #213.

NGTmeaty and koalalorenzo reacted with thumbs up emoji
Copy link
Contributor

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this LGTM!

Copy link
Contributor

The Docker version we compile doesn't get a version number. Might be a different issue, but it'd be nice to get version checking in there too :)

Copy link
Contributor Author

nol166 commented Mar 28, 2019

The Docker version we compile doesn't get a version number. Might be a different issue, but it'd be nice to get version checking in there too :)

The docker image eventually inherits the source code from the binary so as soon as the CI catches up (if and when) this is merged it should work for the docker image as well.

@nol166 nol166 removed the wip label Mar 28, 2019
@nol166 nol166 requested a review from kylecarbs March 28, 2019 20:41
@nol166 nol166 added the enhancement Some improvement that isn't a feature label Apr 1, 2019
Copy link
Contributor Author

nol166 commented Apr 17, 2019

resolved conflicts

@kylecarbs kylecarbs deleted the check-version branch June 19, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher Awaiting requested review from code-asher

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

2 more reviewers

@lsmoura lsmoura lsmoura requested changes

@NGTmeaty NGTmeaty NGTmeaty requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add release number in CLI, tell you when to update.

AltStyle によって変換されたページ (->オリジナル) /