Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(deps): update chrome-remote-interface #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oxy merged 1 commit into main from oxy/update-ws
Jun 4, 2021
Merged

chore(deps): update chrome-remote-interface #3536

oxy merged 1 commit into main from oxy/update-ws
Jun 4, 2021

Conversation

oxy
Copy link

@oxy oxy commented Jun 3, 2021
edited
Loading

Update to fix a security issue (older version depended on a sorely out of date ws 3.3!)

Checklist

  • updated CHANGELOG.md

@oxy oxy requested a review from a team as a code owner June 3, 2021 16:25
Copy link

codecov bot commented Jun 3, 2021
edited
Loading

Codecov Report

Merging #3536 (93a44bf) into main (f364061) will not change coverage.
The diff coverage is n/a.

❗ Current head 93a44bf differs from pull request most recent head 70b032e. Consider uploading reports for the commit 70b032e to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## main #3536 +/- ##
=======================================
 Coverage 59.21% 59.21% 
=======================================
 Files 35 35 
 Lines 1709 1709 
 Branches 379 379 
=======================================
 Hits 1012 1012 
 Misses 559 559 
 Partials 138 138 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f364061...70b032e. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is a security vulnerability or something? Mind adding a why to the description?

Copy link
Author

oxy commented Jun 4, 2021

Yep, it was! Sorry about the lack of description, was in a hurry to handle something yesterday 😅

jsjoeio reacted with thumbs up emoji

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase to main and you're good!

@oxy oxy enabled auto-merge (squash) June 4, 2021 18:34
@oxy oxy merged commit 23eacac into main Jun 4, 2021
@oxy oxy deleted the oxy/update-ws branch June 4, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /