Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(deps): bump ws from 7.4.5 to 7.4.6 #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oxy merged 1 commit into main from dependabot/npm_and_yarn/ws-7.4.6
May 27, 2021
Merged

Conversation

Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 26, 2021
edited
Loading

Bumps ws from 7.4.5 to 7.4.6.

Release notes

Sourced from ws's releases.

7.4.6

Bug fixes

  • Fixed a ReDoS vulnerability (00c425ec).

A specially crafted value of the Sec-Websocket-Protocol header could be used to significantly slow down a ws server.

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
 const value = 'b' + ' '.repeat(length) + 'x';
 const start = process.hrtime.bigint();
value.trim().split(/*,*/);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start);
}

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner May 26, 2021 11:01
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels May 26, 2021
Copy link

codecov bot commented May 26, 2021
edited
Loading

Codecov Report

Merging #3479 (1f107ba) into main (45d736a) will not change coverage.
The diff coverage is n/a.

❗ Current head 1f107ba differs from pull request most recent head 8ee7bca. Consider uploading reports for the commit 8ee7bca to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## main #3479 +/- ##
=======================================
 Coverage 59.21% 59.21% 
=======================================
 Files 35 35 
 Lines 1709 1709 
 Branches 379 379 
=======================================
 Hits 1012 1012 
 Misses 559 559 
 Partials 138 138 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d736a...8ee7bca. Read the comment docs.

Copy link

oxy commented May 27, 2021

@dependabot rebase

dependabot[bot] reacted with thumbs up emoji

Bumps [ws](https://github.com/websockets/ws) from 7.4.5 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.4.5...7.4.6)
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-7.4.6 branch from b1e710b to 8ee7bca Compare May 27, 2021 15:35
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oxy oxy merged commit 87cceb7 into main May 27, 2021
@oxy oxy deleted the dependabot/npm_and_yarn/ws-7.4.6 branch May 27, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@oxy oxy oxy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /