Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Chrome e2e tests #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
foresthoffman wants to merge 70 commits into master from feat/e2e
Closed

Chrome e2e tests #344

foresthoffman wants to merge 70 commits into master from feat/e2e

Conversation

Copy link
Contributor

@foresthoffman foresthoffman commented Mar 27, 2019 •
edited
Loading

Describe in detail the problem you had and how this PR fixes it

  • --port flag
  • --password flag
  • --allow-http flag
  • --no-auth flag
  • Can load in successfully.
  • Can open file
  • Can create file
  • Can delete file
  • Can install extension
  • Can uninstall extension
  • Can debug JavaScript file

Is there an open issue you can link to?

Fixes #339

nol166 reacted with thumbs up emoji
@foresthoffman foresthoffman added the enhancement Some improvement that isn't a feature label Mar 27, 2019
@foresthoffman foresthoffman marked this pull request as ready for review April 1, 2019 19:33
@foresthoffman foresthoffman changed the title (削除) Scaffold chrome e2e tests (削除ここまで) (追記) Chrome e2e tests (追記ここまで) Apr 1, 2019
@foresthoffman foresthoffman force-pushed the feat/e2e branch 8 times, most recently from 60e5c98 to cd69a0f Compare April 8, 2019 16:02
Copy link
Member

code-asher commented Apr 8, 2019 •
edited
Loading

Just had a thought that it might be good to run the tests as Mac, Windows, and Linux clients. Those values are set based on the user agent, could possibly set that? (削除) Or import and override the values provided by src/vs/base/browser/browser.ts around line 126. (削除ここまで) Nah, that won't work since it's tested against the built binary.

Copy link
Contributor Author

@code-asher It is possible to set the user agent for a page with puppeteer: https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagesetuseragentuseragent. I think it uses the base platform to determine the user agent.
code-asher reacted with thumbs up emoji

@foresthoffman foresthoffman force-pushed the feat/e2e branch 5 times, most recently from c483146 to c3c3216 Compare April 9, 2019 01:31
@foresthoffman foresthoffman requested review from kylecarbs and code-asher and removed request for kylecarbs and code-asher April 11, 2019 15:44
@foresthoffman foresthoffman force-pushed the feat/e2e branch 2 times, most recently from b0c240e to dcc1c2e Compare April 18, 2019 02:15
@foresthoffman foresthoffman requested review from kylecarbs and code-asher and removed request for kylecarbs and code-asher April 23, 2019 01:29
Forest Hoffman added 4 commits April 25, 2019 21:22 
$TRAVIS_JOB_NUMBER is unreliable, as it outputs the currently running
job number ($TRAVIS_BUILD_NUMBER.XX) which seems to be the job that
was started last.
@foresthoffman foresthoffman force-pushed the feat/e2e branch 3 times, most recently from 4e362b1 to 6e30eb9 Compare April 27, 2019 01:08
@kylecarbs kylecarbs deleted the feat/e2e branch September 3, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

@code-asher code-asher Awaiting requested review from code-asher

Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E Tests

AltStyle によって変換されたページ (->オリジナル) /