-
Notifications
You must be signed in to change notification settings - Fork 6.3k
docs: add Pomerium #3424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Pomerium #3424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! 🙌
One minor issue with URL (I think)
Codecov Report
Merging #3424 (75e495c) into main (c6d5da1) will not change coverage.
The diff coverage isn/a.
❗ Current head 75e495c differs from pull request most recent head a86c9af. Consider uploading reports for the commit a86c9af to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #3424 +/- ## ======================================= Coverage 59.21% 59.21% ======================================= Files 35 35 Lines 1709 1709 Branches 379 379 ======================================= Hits 1012 1012 Misses 559 559 Partials 138 138
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update c6d5da1...a86c9af. Read the comment docs.
Co-authored-by: Joe Previte <jjprevite@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks so much @desimone 👍🏼
Thanks for making your first contribution! 🙂
If you want to update the CHANGELOG with your change under "New Version" > "Documentation", then we'll make sure to credit you in the Release Notes for this update. Not required though :)
RE: pomerium/pomerium#2223
Checklist
CHANGELOG.md