-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Make sure directories exist #3309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8188556 to
d99267a
Compare
Now that we are creating the directories these shouldn't error. If they are somehow missing (if the user deletes them after VS Code starts for example) then I think we should surface that to the user.
e731f43 to
51d294e
Compare
Codecov Report
Merging #3309 (51d294e) into main (b21a9af) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #3309 +/- ## ======================================= Coverage 58.95% 58.95% ======================================= Files 35 35 Lines 1703 1703 Branches 374 374 ======================================= Hits 1004 1004 Misses 561 561 Partials 138 138
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update b21a9af...51d294e. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo! Really happy we're getting this fix in 👏
Fixes #3040.