-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat(testing): add isConnected check #3271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Merging #3271 (dcdde3d) into main (0d9fe6f) will not change coverage.
The diff coverage isn/a.
❗ Current head dcdde3d differs from pull request most recent head cde3057. Consider uploading reports for the commit cde3057 to get more accurate results
Impacted file tree graph
@@ Coverage Diff @@ ## main #3271 +/- ## ======================================= Coverage 46.90% 46.90% ======================================= Files 23 23 Lines 1196 1196 Branches 237 237 ======================================= Hits 561 561 Misses 451 451 Partials 184 184
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 0d9fe6f...cde3057. Read the comment docs.
120caab to
a5926aa
Compare
@jawnsy
jawnsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
dcdde3d to
cde3057
Compare
Uh oh!
There was an error while loading. Please reload this page.
This PR adds a new check for e2e tests to ensure we have a connection.
Changes
isConnectedmethod toCodeServerisConnectedreloadUntilEditorIsVisibletoreloadUntilEditorIsReady(checks visibility and connection)Screenshots
image
Checklist
Fixes #3270