Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

dev(testing): add jest-playwright and reduce flakiness of e2e tests #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 15 commits into main from jsjoeio/refactor-e2e
Apr 7, 2021

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Apr 1, 2021 •
edited
Loading

This PR adds jest-playwright and refactors the e2e tests to hopefully reduce the flakiness.

Changes

Screenshots

image

image

Checklist

  • tested locally
  • added new dependencies
  • added a test
  • fix flaky logout test
  • remove unused code maybeUpdatedCookies
  • get tests passing locally

Related:

jawnsy reacted with heart emoji
@jsjoeio jsjoeio added this to the v3.9.3 milestone Apr 1, 2021
@jsjoeio jsjoeio self-assigned this Apr 1, 2021
@jsjoeio jsjoeio force-pushed the jsjoeio/refactor-e2e branch 8 times, most recently from d691960 to 4e8b287 Compare April 2, 2021 21:52
@jsjoeio jsjoeio marked this pull request as ready for review April 2, 2021 22:07
@jsjoeio jsjoeio requested a review from a team as a code owner April 2, 2021 22:07
@jsjoeio jsjoeio force-pushed the jsjoeio/refactor-e2e branch 2 times, most recently from 3439941 to ddeebfe Compare April 5, 2021 21:20
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to move the playwright-* packages to devDependencies, and am not sure about .eslintrc order but looks good otherwise!

@jsjoeio jsjoeio force-pushed the jsjoeio/refactor-e2e branch from 1381081 to ca8f832 Compare April 6, 2021 20:49
@jsjoeio jsjoeio requested a review from oxy April 6, 2021 20:49
@jsjoeio jsjoeio force-pushed the jsjoeio/refactor-e2e branch from ca8f832 to ad0f12e Compare April 6, 2021 22:47
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jsjoeio jsjoeio merged commit 15d791a into main Apr 7, 2021
@jsjoeio jsjoeio deleted the jsjoeio/refactor-e2e branch April 7, 2021 17:45
Copy link

dgozman commented Apr 9, 2021

Hi @jsjoeio! Would you consider trying playwright-test instead of jest-playwright? We at Playwright team believe that with the focused test runner it is possible to deliver better experience for e2e tests. If you are open to this, I can guide/help with the migration, as well as address the feedback on the test runner side 😄 Let me know if you are interested!

Copy link
Contributor Author

jsjoeio commented Apr 12, 2021

Hey @dgozman! Thanks for getting in touch. Yes, we would, esp. if the Playwright team recommends it :)

I've opened a new issue for us to discuss + to track us making the switch: #3115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@oxy oxy oxy approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
testing Anything related to testing
Projects
None yet
Milestone
v3.9.3
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /