-
Notifications
You must be signed in to change notification settings - Fork 6.3k
chore(dev-deps): bump @types/node to 12.20.7 #3012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9f30ae5 to
c7d7041
Compare
@oxy
oxy
Apr 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if ~ is intentional here to keep us on the 12.20.x series instead of the 12.x series (which would be behavior for ^) - @jsjoeio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was made intentionally! I was thinking we should stay on 12.20.x series but open to changing it if you think that's the wrong move!
@oxy
oxy
Apr 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about @types/node to know for sure, I think I'd defer to your judgements, though feel free to pull in asher for another opinion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay then. I think we make it strict like this with ~ and if that's the wrong move, then we reverse it. Easily reversible!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we support a range of Node versions I'm not really sure what versions of the types we should use.
I suppose we should keep it in sync with whatever we use to build in CI? So if we use Node 12.20.x then we use 12.20.x types, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in agreement! Sounds good to me!
c7d7041 to
c415fd2
Compare
Uh oh!
There was an error while loading. Please reload this page.
This PR bumps
@types/nodeto12.20.7Tested locally using
node 12.20.2and everything works as expected.Related: