-
Notifications
You must be signed in to change notification settings - Fork 6.3k
dev(testing): separate unit and e2e tests #2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jsjoeio
jsjoeio
changed the title
(削除) jsjoeio-2646-separate-testing (削除ここまで)
(追記) dev(testing): separate unit and e2e tests (追記ここまで)
Mar 9, 2021
jsjoeio
jsjoeio
commented
Mar 10, 2021
.eslintrc.yaml
Outdated
Comment on lines
35
to
41
[
error,
{
alphabetize: { order: "asc" },
groups: [["builtin", "external", "internal"], "parent", "sibling"],
},
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💄
@jsjoeio
jsjoeio
force-pushed
the
jsjoeio-2646-separate-testing
branch
from
March 10, 2021 19:30
e09359a to
5a5c78a
Compare
oxy
oxy
reviewed
Mar 11, 2021
@oxy
oxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the off -> 0 thing, LGTM otherwise!
@jsjoeio
jsjoeio
force-pushed
the
jsjoeio-2646-separate-testing
branch
from
March 12, 2021 19:01
5a5c78a to
7e23575
Compare
oxy
oxy
approved these changes
Mar 15, 2021
@oxy
oxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merged
@jsjoeio
jsjoeio
added
testing
Anything related to testing
chore
Related to maintenance or clean up
labels
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2646 by separating unit and e2e testing. Hopefully this speeds things up with CI.