Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Remove default home #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 2 commits into master from no-default-home
Mar 2, 2021
Merged

Remove default home #2800

code-asher merged 2 commits into master from no-default-home
Mar 2, 2021

Conversation

Copy link
Member

@code-asher code-asher commented Mar 1, 2021

No description provided.

frenck reacted with thumbs up emoji frenck reacted with rocket emoji 
This is preventing my ripgrep from searching vscode.
@code-asher code-asher changed the title (削除) Removeo default home (削除ここまで) (追記) Remove default home (追記ここまで) Mar 1, 2021
@code-asher code-asher requested a review from a team March 1, 2021 19:21
@code-asher code-asher changed the base branch from v3.9.0 to master March 1, 2021 19:22
@jsjoeio jsjoeio added this to the v3.9.1 milestone Mar 1, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are my favorite kind of PRs: short and sweet

  • tested by setting home in config. still works!
  • tested if home icon is removed when home isn't set

image

code-asher reacted with heart emoji
@greyscaled greyscaled linked an issue Mar 2, 2021 that may be closed by this pull request
@code-asher code-asher merged commit 29f3021 into master Mar 2, 2021
@code-asher code-asher deleted the no-default-home branch March 2, 2021 16:13
Copy link

"--home" no longer works on v3.9.2

Copy link
Contributor

jsjoeio commented Mar 29, 2021 •
edited
Loading

@reggiezhang apologies! (削除) That should have been mentioned in the release notes (updating now) (削除ここまで) Added to release notes for 3.9.2.

VS Code removed that option so we had to remove it from code-server here: #2862

reggiezhang reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

Remove default home value

AltStyle によって変換されたページ (->オリジナル) /