Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Open localhost URL with --open #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylecarbs merged 2 commits into coder:master from fand:cli-open
Mar 7, 2019
Merged

Open localhost URL with --open #28

kylecarbs merged 2 commits into coder:master from fand:cli-open
Mar 7, 2019

Conversation

Copy link
Contributor

@fand fand commented Mar 6, 2019

CLI option --open is not working now.

I implemented --open with this npm package:
https://github.com/sindresorhus/opn

@fand fand closed this Mar 6, 2019
@fand fand reopened this Mar 6, 2019
Co-Authored-By: fand <fand@users.noreply.github.com>
Copy link
Contributor Author

fand commented Mar 7, 2019

seems tests are failing beacuse of API rate limit on cloning vscode-ripgrep.
I'll close/reopen PR just to trigger rebuild.

@fand fand closed this Mar 7, 2019
@fand fand reopened this Mar 7, 2019
Copy link
Contributor

sr229 commented Mar 7, 2019

@frand It's a Travis-side issue. NPMJS seems to ratelimit the CI fsr, recommend you wait it out for 3 hours

kylecarbs reacted with thumbs up emoji

@fand fand closed this Mar 7, 2019
@fand fand reopened this Mar 7, 2019
Copy link
Member

We'll be fixing the CI for PRs soon.

fand reacted with thumbs up emoji

@kylecarbs kylecarbs merged commit 87d2e22 into coder:master Mar 7, 2019
code-asher pushed a commit that referenced this pull request Jun 19, 2019
* Open localhost URL with --open
* Catch errors on opn
Co-Authored-By: fand <fand@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@code-asher code-asher Awaiting requested review from code-asher

+1 more reviewer

@foresthoffman foresthoffman foresthoffman requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /