-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Open localhost URL with --open #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foresthoffman
foresthoffman
suggested changes
Mar 6, 2019
Co-Authored-By: fand <fand@users.noreply.github.com>
kylecarbs
kylecarbs
approved these changes
Mar 7, 2019
seems tests are failing beacuse of API rate limit on cloning vscode-ripgrep
.
I'll close/reopen PR just to trigger rebuild.
@frand It's a Travis-side issue. NPMJS seems to ratelimit the CI fsr, recommend you wait it out for 3 hours
We'll be fixing the CI for PRs soon.
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
* Open localhost URL with --open * Catch errors on opn Co-Authored-By: fand <fand@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI option
--open
is not working now.I implemented
--open
with this npm package:https://github.com/sindresorhus/opn