-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat(testing): add tests for serviceWorker.ts #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jsjoeio
jsjoeio
changed the base branch from
add-tests-emitter
to
add-tests-register
February 18, 2021 21:47
jsjoeio
jsjoeio
commented
Feb 18, 2021
@jsjoeio
jsjoeio
force-pushed
the
add-tests-serviceWorker
branch
from
February 18, 2021 23:54
9a135e6 to
4d75321
Compare
oxy
oxy
approved these changes
Feb 22, 2021
@oxy
oxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Your call on the ; in one of the patches we apply; I think internal consistency with the patched file may be the best.
@jsjoeio
jsjoeio
force-pushed
the
add-tests-register
branch
3 times, most recently
from
February 23, 2021 23:03
14ad29a to
909d425
Compare
@jsjoeio
jsjoeio
force-pushed
the
add-tests-serviceWorker
branch
from
February 24, 2021 17:09
4d75321 to
040c0d6
Compare
@jsjoeio
jsjoeio
force-pushed
the
add-tests-serviceWorker
branch
from
February 24, 2021 18:23
5b4711c to
f1f0f49
Compare
EDIT: this time it was a network timeout. Running again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds a few tests for
src/browser/serviceWorker.ts.Screenshot
image
It increases our code coverage (Lines) from 51.31% to 51.74% (β 0.43%).
π© 100% Line coverage (last 100) for
src/browser/serviceWorker.tsimage
This also completes Lines coverage for
src/browserπimage
TODOS