Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(install): add Azure and Heroku #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpmct merged 3 commits into coder:master from bpmct:add-heroku-azure
Feb 22, 2021
Merged

Conversation

Copy link
Member

@bpmct bpmct commented Feb 16, 2021

Adds an initial section in install.md for deploying code-server to app engines.

closes #2711, #2686

@bpmct bpmct requested a review from jsjoeio February 16, 2021 05:46
Copy link
Member Author

bpmct commented Feb 16, 2021

@jsjoeio You had also mentioned mentioning awesome-code-server in the docs. I can make it an official cdr repo, and then add it in the FAQ. Should I include that in this PR or another?

Copy link
Member Author

bpmct commented Feb 16, 2021

if this is better suited as a FAQ piece, let me know. wasn't sure what made the most sense with docs.

@bpmct bpmct added the docs Documentation related label Feb 16, 2021
@jsjoeio jsjoeio changed the title (削除) add Azure, Heroku to install docs (削除ここまで) (追記) docs(install): add Azure and Heroku (追記ここまで) Feb 18, 2021
@jsjoeio jsjoeio added this to the v3.9.1 milestone Feb 18, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this Ben 🎉

Copy link
Contributor

jsjoeio commented Feb 18, 2021

You had also mentioned mentioning awesome-code-server in the docs. I can make it an official cdr repo, and then add it in the FAQ. Should I include that in this PR or another?

Up to you! Whatever you prefer. You can either add it here and re-request a review, or merge this and open a separate PR

Copy link
Contributor

jsjoeio commented Feb 22, 2021

bump @bpmct

Copy link
Member Author

bpmct commented Feb 22, 2021

oops, forgot to push. wasn't quite sure where to put it/how to word it in the FAQ. whatever fits best for the overall style I'm down for @jsjoeio

jsjoeio reacted with heart emoji

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it 🚢

@bpmct bpmct merged commit 74d2652 into coder:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docs Documentation related
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /