-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat(testing): add unit tests for emitter #2715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxy
oxy
reviewed
Feb 12, 2021
jsjoeio
jsjoeio
commented
Feb 18, 2021
@jsjoeio
jsjoeio
force-pushed
the
add-tests-emitter
branch
from
February 18, 2021 23:56
1896154 to
5e287ad
Compare
code-asher
code-asher
approved these changes
Feb 22, 2021
@jsjoeio
jsjoeio
force-pushed
the
add-tests-emitter
branch
from
February 22, 2021 20:44
5e287ad to
325a1d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds a few tests for
src/common/emitter.ts.Screenshot
image
It increases our code coverage (Lines) from 50.09% to 50.26% (β 0.17%).
π© 100% Line coverage (last 100) for
src/common/emitter.tsand also 100% coverage forsrc/commonimage
TODOS