Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Move helm from root and fix stuff in README #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhooyr merged 4 commits into master from helm-db7f
Nov 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/CODEOWNERS
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
charts/code-server @Matthew-Beckett @alexgorbatchev
* @code-asher @nhooyr
* @code-asher @nhooyr

ci/helm-chart @Matthew-Beckett @alexgorbatchev
14 changes: 0 additions & 14 deletions .github/workflows/helm_validation.yaml
View file Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion ci/dev/fmt.sh
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ main() {
"*.yaml"
"*.yml"
)
prettier --write --loglevel=warn $(git ls-files "${prettierExts[@]}")
prettier --write --loglevel=warn $(
git ls-files "${prettierExts[@]}" | grep -v 'helm-chart'
)

doctoc --title '# FAQ' doc/FAQ.md > /dev/null
doctoc --title '# Setup Guide' doc/guide.md > /dev/null
Expand Down
1 change: 1 addition & 0 deletions ci/dev/lint.sh
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ main() {
stylelint $(git ls-files "*.css")
tsc --noEmit
shellcheck -e SC2046,SC2164,SC2154,SC1091,SC1090,SC2002 $(git ls-files "*.sh")
helm kubeval ci/helm-chart
}

main "$@"
File renamed without changes.
File renamed without changes.
23 changes: 13 additions & 10 deletions charts/code-server/README.md → ci/helm-chart/README.md
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ This chart is community maintained by [@Matthew-Beckett](https://github.com/Matt
## TL;DR;

```console
$ git clone https://github.com/cdr/code-server.git
$ helm install code-server/charts/code-server
$ git clone https://github.com/cdr/code-server
$ cd code-server
$ helm upgrade --install code-server ci/helm-chart
```

## Introduction
Expand All @@ -26,10 +27,12 @@ package manager.

## Installing the Chart

To install the chart with the release name `my-release`:
To install the chart with the release name `code-server`:

```console
$ helm install --name my-release charts/code-server
$ git clone https://github.com/cdr/code-server
$ cd code-server
$ helm upgrade --install code-server ci/helm-chart
```

The command deploys code-server on the Kubernetes cluster in the default
Expand All @@ -40,10 +43,10 @@ that can be configured during installation.

## Uninstalling the Chart

To uninstall/delete the `my-release` deployment:
To uninstall/delete the `code-server` deployment:

```console
$ helm delete my-release
$ helm delete code-server
```

The command removes all the Kubernetes components associated with the chart and
Expand Down Expand Up @@ -97,9 +100,9 @@ Specify each parameter using the `--set key=value[,key=value]` argument to `helm
install`. For example,

```console
$ helm install --name my-release \
--set persistence.enabled=false \
deployment/chart
$ helm install code-server \
Copy link
Collaborator

@sreya sreya Nov 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could potentially do helm upgrade --install to cover both install and upgrades

nhooyr and Matthew-Beckett reacted with thumbs up emoji
ci/helm-chart \
--set persistence.enabled=false
```

The above command sets the the persistence storage to false.
Expand All @@ -108,7 +111,7 @@ Alternatively, a YAML file that specifies the values for the above parameters
can be provided while installing the chart. For example,

```console
$ helm install --name my-release -f values.yaml deployment/chart
$ helm install code-server ci/helm-chart -f values.yaml
```

> **Tip**: You can use the default [values.yaml](values.yaml)
File renamed without changes.
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ persistence:
##
# storageClass: "-"
accessMode: ReadWriteOnce
size: 1Gi
size: 10Gi
annotations: {}
# existingClaim: ""
# hostPath: /data
Expand Down
6 changes: 6 additions & 0 deletions ci/images/debian10/Dockerfile
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,10 @@ ENV GO111MODULE=on
RUN go get mvdan.cc/sh/v3/cmd/shfmt
RUN go get github.com/goreleaser/nfpm/cmd/nfpm

RUN VERSION="$(curl -fsSL https://storage.googleapis.com/kubernetes-release/release/stable.txt)" && \
curl -fsSL "https://storage.googleapis.com/kubernetes-release/release/$VERSION/bin/linux/amd64/kubectl" > /usr/local/bin/kubectl \
&& chmod +x /usr/local/bin/kubectl
RUN curl -fsSL https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
RUN helm plugin install https://github.com/instrumenta/helm-kubeval

RUN curl -fsSL https://get.docker.com | sh
5 changes: 5 additions & 0 deletions doc/install.md
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- [macOS](#macos)
- [Standalone Releases](#standalone-releases)
- [Docker](#docker)
- [helm](#helm)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

Expand Down Expand Up @@ -192,3 +193,7 @@ Our official image supports `amd64` and `arm64`.
For `arm32` support there is a popular community maintained alternative:

https://hub.docker.com/r/linuxserver/code-server

## helm

See [the chart](../ci/helm-chart).

AltStyle によって変換されたページ (->オリジナル) /