Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed documentation download links based on latest version #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylecarbs merged 6 commits into coder:master from MoienTajik:master
Mar 18, 2019
Merged

Fixed documentation download links based on latest version #130

kylecarbs merged 6 commits into coder:master from MoienTajik:master
Mar 18, 2019

Conversation

Copy link
Contributor

@MoienTajik MoienTajik commented Mar 8, 2019

Describe in detail the problem you had and how this PR fixes it

The specified download links in the Docs is no longer exist and gives 404 not found: https://github.com/codercom/code-server/releases/download/0.1.4/code-server-linux

Fixed by replacing them with the latest release links.

Is there an open issue you can link to?

No

Copy link
Member

Might be better to generalize or remove these commands so we don't need to update the README on each release.

Copy link
Contributor Author

It could be better if the latest version always exists on the Coder.com website with a general URL which always points to the latest version. So this URL could always be referenced in the documentation, like: https://coder.com/releases/download/latest/code-server-linux

Another option could be /releases/latest in Github.

Copy link
Member

I'm good with using /releases/latest.

MoienTajik, avelino, and MichaelDesantis reacted with thumbs up emoji

Copy link
Contributor Author

Updated based on /releases/latest.

Copy link
Contributor

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

Ping !

@kylecarbs kylecarbs merged commit 91a98b8 into coder:master Mar 18, 2019
code-asher pushed a commit that referenced this pull request Jun 19, 2019
* Fixed documentation based on latest release
* Fixed google-cloud documentation steps order
* Edited docs based on the latest release versions
* Make docs more dynamic based on Releases
* Changed ordered list to unordered list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher requested changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

+1 more reviewer

@avelino avelino avelino requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /