Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[22.05.05] 정기적 풀이 추가 (2문제) #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeisneverodd merged 3 commits into codeisneverodd:main from yongchanson:main
May 6, 2022

Conversation

Copy link
Contributor

@yongchanson yongchanson commented May 4, 2022

2문제 풀이추가하였고
풀이만 추가하는 경우 add가 맞는거 같은데
저도 그렇고 update랑 혼용해서 사용하는 분들이 계시네요!

Copy link
Owner

@codeisneverodd codeisneverodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 코드 잘 보았습니다 😁
말씀대로 저도 커밋 컨벤션을 혼용해서 쓰고 있었네요! 많은 사람들이 헷갈리는 것을 보니 커밋 컨벤션을 수정하는 것도 생각해보아야할 것 같습니다!!

Copy link
Owner

@codeisneverodd codeisneverodd May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for 문에 var을 쓰시는 특별한 이유가 있으신지 궁금합니다!

Copy link
Contributor Author

@yongchanson yongchanson May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실수입니다 ᅲ
수정했습니다.

@codeisneverodd codeisneverodd merged commit b3e9f55 into codeisneverodd:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeisneverodd codeisneverodd codeisneverodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /