Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: use organization workflows for improve actions #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datamweb wants to merge 3 commits into codeigniter4:develop
base: develop
Choose a base branch
Loading
from datamweb:refactor-smarting-comment

Conversation

Copy link
Collaborator

@datamweb datamweb commented Feb 28, 2024 •
edited
Loading

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added github_actions Pull requests that update GitHub Actions code tests needed Pull requests that need tests and removed tests needed Pull requests that need tests labels Feb 28, 2024
Copy link
Collaborator Author

datamweb commented Feb 28, 2024 •
edited
Loading 

[Invalid workflow file: .github/workflows/smart-commenting.yml#L21](https://github.com/codeigniter4/shield/actions/runs/8082359503/workflow)
error parsing called workflow
".github/workflows/smart-commenting.yml"
-> "codeigniter4/.github/.github/workflows/label-signing.yml@main" (source branch with sha:d8ea2aa19c2eb2b6482402133f328a6105d2aa22)
: workflow is not reusable as it is missing a `on.workflow_call` trigger

[Invalid workflow file: .github/workflows/smart-commenting.yml#L23](https://github.com/codeigniter4/shield/actions/runs/8082300366/workflow)
error parsing called workflow
".github/workflows/smart-commenting.yml"
-> "codeigniter4/.github/.github/workflows/label-add-conflict-all-pr.yml@main" (source branch with sha:d8ea2aa19c2eb2b6482402133f328a6105d2aa22)
: workflow is not reusable as it is missing a `on.workflow_call` trigger

See https://github.com/orgs/community/discussions/38954

@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Feb 28, 2024
Copy link
Member

kenjis commented Feb 28, 2024

I'm not sure, but we can't use branch names in this workflow, only tag names?

kenjis added a commit to codeigniter4/.github that referenced this pull request Mar 22, 2024
Copy link
Member

kenjis commented Mar 22, 2024

@datamweb I sent PR codeigniter4/.github#26

datamweb reacted with thumbs up emoji

@kenjis kenjis added GPG-Signing needed Pull requests that need GPG-Signing and removed GPG-Signing needed Pull requests that need GPG-Signing labels Mar 23, 2024
@kenjis kenjis reopened this Mar 23, 2024
@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Mar 23, 2024
@datamweb datamweb force-pushed the refactor-smarting-comment branch from 922ec11 to ba08f4b Compare March 23, 2024 00:25
@datamweb datamweb removed the GPG-Signing needed Pull requests that need GPG-Signing label Mar 23, 2024
@datamweb datamweb marked this pull request as draft March 23, 2024 00:27
Copy link
Collaborator Author

datamweb commented Mar 23, 2024 •
edited
Loading 

[Invalid workflow file: .github/workflows/smart-commenting.yml#L20](https://github.com/codeigniter4/shield/actions/runs/8398026883/workflow)
The workflow is not valid. .github/workflows/smart-commenting.yml (Line: 20, Col: 3): Error calling workflow 'codeigniter4/.github/.github/workflows/label-signing.yml@main'. The workflow is requesting 'pull-requests: write', but is only allowed 'pull-requests: none'.

(削除) But why we have set access pull-requests: write in .github
https://github.com/codeigniter4/.github/blob/567aab8e987fccac5b1864d0635ec087b12d0866/.github/workflows/label-signing.yml#L12-L14 (削除ここまで)

@datamweb datamweb added the GPG-Signing needed Pull requests that need GPG-Signing label Mar 23, 2024
@datamweb datamweb marked this pull request as ready for review March 23, 2024 01:06
@datamweb datamweb force-pushed the refactor-smarting-comment branch 2 times, most recently from b4d1c91 to 780c5a5 Compare March 23, 2024 01:16
@datamweb datamweb added tests needed Pull requests that need tests and removed GPG-Signing needed Pull requests that need GPG-Signing tests needed Pull requests that need tests labels Mar 23, 2024
Copy link
Collaborator Author

It seems to be working fine now, please check it.

Copy link
Member

kenjis commented Mar 23, 2024

What is Smart Commenting-refactor-smarting-comment?

Smart Commenting: .github#L1
Canceling since a higher priority waiting request for 'Smart Commenting-refactor-smarting-comment' exists
https://github.com/codeigniter4/shield/actions/runs/8398353923

datamweb reacted with eyes emoji

Copy link
Member

kenjis commented Mar 23, 2024

add-comment-for-conflict / Check Conflicts

Run IFS=$'\n' # Set Internal Field Separator to newline to handle array elements
GraphQL: Resource not accessible by integration (addLabelsToLabelable)
Error: Process completed with exit code 1.
https://github.com/codeigniter4/shield/actions/runs/8398353923/job/23003407973

datamweb reacted with eyes emoji

@datamweb datamweb added testing Pull requests that changes tests only tests needed Pull requests that need tests and removed testing Pull requests that changes tests only labels Mar 23, 2024
Copy link
Collaborator Author

datamweb commented Mar 23, 2024 •
edited
Loading

(削除) codeigniter4/.github/.github/workflows/label-add-conflict-all-pr.yml@main" (source branch with sha:d8ea2aa19c2eb2b6482402133f328a6105d2aa22)\r\n: workflow is not reusable as it is missing a on.workflow_call trigger (削除ここまで)

@datamweb datamweb removed the tests needed Pull requests that need tests label Mar 23, 2024
@datamweb datamweb added tests needed Pull requests that need tests and removed tests needed Pull requests that need tests labels Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /