-
Notifications
You must be signed in to change notification settings - Fork 43
For Windows OS, revert the usage of cmd.exe by default (new option)#110
For Windows OS, revert the usage of cmd.exe by default (new option) #110axel3rd wants to merge 1 commit intocodehaus-plexus:master from
Conversation
c7a10b4 to
84109d4
Compare
8f20b85 to
971980d
Compare
971980d to
ff8e0e4
Compare
axel3rd
commented
Dec 21, 2020
Note: GitHub action verify problem with Java 16-ea is not part of this PR.
axel3rd
commented
Jan 4, 2021
(@michael-o: Requested changes have been done)
axel3rd
commented
Jan 4, 2021
Note: GitHub action verify problem with Java 16-ea is not part of this PR.
See #116
axel3rd
commented
Feb 26, 2021
Is this PR (or #109) not relevant 😢 ?
michael-o
commented
Feb 26, 2021
I will try to pick this up next month.
axel3rd
commented
Feb 26, 2021
Thank you !
axel3rd
commented
Jul 28, 2021
I will try to pick this up next month.
😁 (#FriendlyBump)
michael-o
commented
Jul 29, 2021
Thanks for the note. I think both Bourne Shell and Cmd Shell must go. There is no use for that.
axel3rd
commented
Jul 29, 2021
I think both Bourne Shell and Cmd Shell must go. There is no use for that
=> We abandon this PR, and perhaps #109 depending the relevance ?
michael-o
commented
Jul 29, 2021
I first need to understand why this was done at all. Maybe lack of knowledge. Currently, I don't see a reason why we should wrap these command into a shell execution at all.
rfscholte
commented
Jul 29, 2021
From what I've always understood only with a new shell you can isolate system properties and environment variables.
michael-o
commented
Jul 29, 2021
System properties are pure args to a process. There is no connection to the parent process. If want to isolate env vars, you can do that easily with the ProcessBuilder. It works just fine. Moreover, you cannot start with a nude environment because some processes expect default env vars and they won't be present. Just set those you need and that's it.
Uh oh!
There was an error while loading. Please reload this page.
This PR is an update of old previous staling PR #42
cf. #17 (comments from May 2018): Revert the usage of
cmd.exeby default (on Windows), because prevents the destroy/kill launched by this way whenCTRL+C.Allow this behavior by the usage of a new method:
This PR should be chosen or #109.